streamlined error handling and added timeout option #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error handling has been streamlined so that callbacks are invoked in error cases in every method. A request timeout option has been added for backend requests. A timeout passed to hte constructor is used as the global default while timeouts set in method options are only used in the method call-
sowo
changed the title
authenticate_refresh is invoked without callback. Using standard error handling doesn't work in this case.
|
@sowo can you clean up this commit to show only what needs to be changed? Looking at it, it seems like the whole file changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling has been streamlined so that callbacks are invoked in
error cases in every method.
A request timeout option has been added for backend requests. A timeout
passed to the constructor is used as the global default while timeouts
set in method options are only used in the method call-